Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add foundry tests #196

Merged
merged 11 commits into from
Feb 3, 2024
Merged

test: add foundry tests #196

merged 11 commits into from
Feb 3, 2024

Conversation

Schlagonia
Copy link
Collaborator

@Schlagonia Schlagonia commented Feb 1, 2024

Description

add foundry test to use fuzzing and standard 4626 property tests.

  • Found that setting deposit_limit to max uint256 causes reverts in maxMint, maxWithdraw and maxRedeem

Must be run separately than the ape tests and after ape compile. Runs with forge test

Fixes # (issue)

Checklist

  • I have run vyper and solidity linting
  • I have run the tests on my machine
  • I have followed commitlint guidelines
  • I have rebased my changes to the latest version of the main branch

Copy link
Collaborator

@fp-crypto fp-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would like to see tests passing

@Schlagonia
Copy link
Collaborator Author

LGTM, but would like to see tests passing

Tests are all passing in the CI and locally.

the CI failure is from the commit lint. It doesnt like the forge isntall commit

@Schlagonia Schlagonia merged commit c8fab70 into 3.0.2 Feb 3, 2024
7 of 8 checks passed
@Schlagonia Schlagonia deleted the foundry_tests branch February 3, 2024 00:02
Schlagonia added a commit that referenced this pull request Feb 5, 2024
* feat: update api and ape version

* chore: removals (#189)

* chore: remove increase and decrease allowances

* chore: remove open roles

* feat: add max loss to debt updates (#190)

* feat: use cloning for vaults (#191)

* feat: use cloning for vaults

* fix: scripts

* chore: fix interfaces

* chore: lower case factory

* fix: update to strategy changes

* feat: add to queue flag (#195)

* fix: updated strategy branch

* feat: minor fixes (#194)

* fix: redeem corrections

* chore: dont burn zero shares

* fix: use updated strategy storage

* fix: rebase

* chore: bump oz version

* fix: oz 4626 fix

* fix: lossy test

* fix: round down in max redeem

* fix: comment

* chore: ignore snapshot

* test: add foundry tests (#196)

* chore: setup foundry test

* chore: add remappings

* forge install: erc4626-tests

* test: add foundry fuzzing tests

* fix: max uint deposit limit

* fix: test strategy

* fix: foundry runner

* fix: clamp overflow

* fix: default tests

* chore: clean up linting

* fix: new strategy version

* fix: reporting costs (#192)

* test: for no locking

* chore: cheaper reports

* chore: track current debt

* chore: lower unlocked gas

* fix: set to 0

* build: only burn or mint (#193)

* build: only burn or mint

* build: target end supply

* chore: comments

* fix: comments

* fix: strategy changes

* chore: rebase

* fix: decimal type

* chore: deployment and interfaces

* fix: black

* chore: updated strategy branch

* fix: foundry remapping
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMPROVEMENT - Run ERC4626 property tests to detect standard violations
2 participants