Handle DependencyFileNotParseable error on Updater.run (dependabot#11288

)

* Handle DependencyFileNotParseable error on Updater.run

* Stop handling standard error

* Fix failing CI checks

* Count error as stdout

* Remove rescued exception from stdout test

common/lib/dependabot/errors.rb

@@ -166,6 +166,7 @@ def self.parser_error_details(error)
 
   # rubocop:disable Lint/RedundantCopDisableDirective
   # rubocop:disable Metrics/CyclomaticComplexity
+  # rubocop:disable Metrics/AbcSize
   sig { params(error: StandardError).returns(T.nilable(T::Hash[Symbol, T.untyped])) }
   def self.updater_error_details(error)
     case error
@@ -179,6 +180,14 @@ def self.updater_error_details(error)
         "error-type": "dependency_file_not_evaluatable",
         "error-detail": { message: error.message }
       }
+    when Dependabot::DependencyFileNotParseable
+      {
+        "error-type": "dependency_file_not_parseable",
+        "error-detail": {
+          message: error.message,
+          "file-path": error.file_path
+        }
+      }
     when Dependabot::GitDependenciesNotReachable
       {
         "error-type": "git_dependencies_not_reachable",
@@ -294,6 +303,7 @@ def self.updater_error_details(error)
   # rubocop:enable Metrics/MethodLength
   # rubocop:enable Metrics/CyclomaticComplexity
   # rubocop:enable Lint/RedundantCopDisableDirective
+  # rubocop:enable Metrics/AbcSize
 
   class DependabotError < StandardError
     extend T::Sig

silent/tests/testdata/vu-group-semver-error.txt

@@ -2,7 +2,6 @@
 
 ! dependabot update -f input.yml --local . --updater-image ghcr.io/dependabot/dependabot-updater-silent
 # If this appears in the logs twice that means it tried to create a PR again
-stderr -count=1 DependencyFileNotParseable
 stdout -count=2 create_pull_request
 pr-created expected-group.json
 pr-created expected-individual.json

updater/lib/dependabot/update_files_command.rb

@@ -37,11 +37,16 @@ def perform_job
         #
         # As above, we can remove the responsibility for handling fatal/job halting
         # errors from Dependabot::Updater entirely.
-        Dependabot::Updater.new(
-          service: service,
-          job: job,
-          dependency_snapshot: dependency_snapshot
-        ).run
+        begin
+          Dependabot::Updater.new(
+            service: service,
+            job: job,
+            dependency_snapshot: dependency_snapshot
+          ).run
+        rescue Dependabot::DependencyFileNotParseable => e
+          handle_dependency_file_not_parseable_error(e)
+          return service.mark_job_as_processed(Environment.job_definition["base_commit_sha"])
+        end
 
         # Wait for all PRs to be created
         service.wait_for_calls_to_finish
@@ -129,5 +134,20 @@ def handle_parser_error(error)
       )
     end
     # rubocop:enable Metrics/AbcSize, Layout/LineLength, Metrics/MethodLength
+
+    def handle_dependency_file_not_parseable_error(error)
+      error_details = Dependabot.updater_error_details(error)
+
+      service.record_update_job_error(
+        error_type: T.must(error_details).fetch(:"error-type"),
+        error_details: T.must(error_details)[:"error-detail"]
+      )
+      return unless Experiments.enabled?(:record_update_job_unknown_error)
+
+      service.record_update_job_unknown_error(
+        error_type: T.must(error_details).fetch(:"error-type"),
+        error_details: T.must(error_details)[:"error-detail"]
+      )
+    end
   end
 end

updater/spec/dependabot/update_files_command_spec.rb

@@ -296,6 +296,38 @@
       end
     end
 
+    context "with a Dependabot::DependencyFileNotParseable error" do
+      let(:error) { Dependabot::DependencyFileNotParseable.new("path/to/file", "a") }
+
+      let(:snapshot) do
+        instance_double(Dependabot::DependencySnapshot,
+                        base_commit_sha: "1c6331732c41e4557a16dacb82534f1d1c831848")
+      end
+
+      let(:updater) do
+        instance_double(Dependabot::Updater,
+                        service: service,
+                        job: job,
+                        dependency_snapshot: snapshot)
+      end
+
+      before do
+        allow(Dependabot::DependencySnapshot).to receive(:create_from_job_definition).and_return(snapshot)
+        allow(Dependabot::Updater).to receive(:new).and_return(updater)
+        allow(updater).to receive(:run).and_raise(error)
+      end
+
+      it "only records a job error" do
+        expect(service).not_to receive(:capture_exception)
+        expect(service).to receive(:record_update_job_error).with(
+          error_type: "dependency_file_not_parseable",
+          error_details: { "file-path": "path/to/file", message: "a" }
+        )
+
+        perform_job
+      end
+    end
+
     context "with a Dependabot::DependencyFileNotFound error" do
       let(:error) { Dependabot::DependencyFileNotFound.new("path/to/file") }