enable some eslint rules

.xo-config.json

@@ -8,23 +8,23 @@
     "project": "./tsconfig.spec.json"
   },
   "rules": {
-    "no-await-in-loop": "off",
-    "prefer-rest-params": "off",
-    "prefer-spread": "off",
-    "unicorn/prefer-spread": "off",
-    "unicorn/no-array-callback-reference": "off",
-    "unicorn/no-object-as-default-parameter": "off",
-    "unicorn/no-this-assignment": "off",
     "@typescript-eslint/no-unsafe-argument": "off",
     "@typescript-eslint/no-unsafe-assignment": "off",
     "@typescript-eslint/no-unsafe-call": "off",
-    "@typescript-eslint/no-unsafe-return": "off"
+    "@typescript-eslint/no-unsafe-return": "off",
+    "no-await-in-loop": "off",
+    "prefer-spread": "off"
   },
   "overrides": [
     {
       "files": "test/*",
       "rules": {
         "max-nested-callbacks": "off",
+        "prefer-rest-params": "off",
+        "unicorn/prefer-spread": "off",
+        "unicorn/no-array-callback-reference": "off",
+        "unicorn/no-object-as-default-parameter": "off",
+        "unicorn/no-this-assignment": "off",
         "@typescript-eslint/no-empty-function": "off",
         "@typescript-eslint/no-unused-expressions": "off",
         "@typescript-eslint/restrict-plus-operands": "off",

src/actions/help.ts

@@ -62,7 +62,7 @@ export class HelpMixin extends GeneratorOrigin {
     let args = '';
 
     if (this._arguments.length > 0) {
-      args = this._arguments.map(formatArg).join(' ') + ' ';
+      args = this._arguments.map(arg => formatArg(arg)).join(' ') + ' ';
     }
 
     name = name.replace(/^yeoman:/, '');

src/actions/lifecycle.ts

@@ -210,7 +210,7 @@ export abstract class TasksMixin extends GeneratorOrigin {
    */
   getTaskNames(): string[] {
     const methods = Object.getOwnPropertyNames(Object.getPrototypeOf(this));
-    let validMethods = methods.filter(methodIsValid);
+    let validMethods = methods.filter(method => methodIsValid(method));
     const { taskPrefix } = this.features;
 
     if (taskPrefix) {

src/generator-parent.ts

@@ -2,7 +2,7 @@ import type { BaseEnvironment, BaseGenerator, PromptAnswers, PromptQuestions } f
 import type Storage from './util/storage.js';
 import type { BaseFeatures, BaseOptions } from './index.js';
 
-export class GeneratorOrigin implements BaseGenerator {
+export abstract class GeneratorOrigin implements BaseGenerator {
   declare env: BaseEnvironment;
   declare _destinationRoot: string | undefined;
   declare _namespace: string;

src/util/deprecate.js

@@ -2,9 +2,9 @@ import _ from 'lodash';
 import chalk from 'chalk';
 
 const deprecate = (message, fn) => {
-  return function () {
+  return function (...args) {
     deprecate.log(message);
-    return Reflect.apply(fn, this, arguments);
+    return Reflect.apply(fn, this, args);
   };
 };