Skip to content

Commit

Permalink
extract the welcome message into a separate module
Browse files Browse the repository at this point in the history
  • Loading branch information
sindresorhus committed Jan 20, 2015
1 parent 66df157 commit b611741
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 28 deletions.
6 changes: 4 additions & 2 deletions lib/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ var fileLogger = { write: _.noop, warn: _.noop };
* Every generator should extend this base class.
*
* @constructor
* @mixes util/common
* @mixes actions/actions
* @mixes actions/fetch
* @mixes actions/file
Expand Down Expand Up @@ -190,11 +189,14 @@ _.extend(Base.prototype, require('./actions/string'));
_.extend(Base.prototype, require('./actions/remote'));
_.extend(Base.prototype, require('./actions/wiring'));
_.extend(Base.prototype, require('./actions/help'));
_.extend(Base.prototype, require('./util/common'));
Base.prototype.user = require('./actions/user');
Base.prototype.invoke = require('./actions/invoke');
Base.prototype.spawnCommand = require('./actions/spawn_command');

// TODO: Remove before 1.0.0
// DEPRECATED: Use the module directly
Base.prototype.welcome = require('yeoman-welcome');

/**
* Prompt user to answer questions. The signature of this method is the same as {@link https://github.com/SBoudrias/Inquirer.js Inquirer.js}
*
Expand Down
25 changes: 0 additions & 25 deletions lib/util/common.js

This file was deleted.

3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@
"user-home": "^1.1.0",
"xdg-basedir": "^1.0.0",
"yeoman-assert": "^1.0.0",
"yeoman-environment": "^1.1.0"
"yeoman-environment": "^1.1.0",
"yeoman-welcome": "^1.0.0"
},
"devDependencies": {
"gulp": "^3.6.0",
Expand Down

1 comment on commit b611741

@JayGray
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sindresorhus would be nice to have this API change documented.
thx keep coding

Please sign in to comment.