Add a sort_fonts function that internally calls FCFontSort.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @wezm 👋🏽 Thanks for maintaining such a fantastic crate. Would love your thoughts on this and whether this is a change you'd accept. Please let me know if you have any questions on the approach! |
wezm
requested changes
Jan 17, 2024
| @@ -511,6 +529,17 @@ pub fn list_fonts<'fc>(pattern: &Pattern<'fc>, objects: Option<&ObjectSet>) -> F | |||
| } | |||
| } | |||
|
|
|||
| /// Returns a `FontSet` containing fonts sorted by closeness to the supplied `pattern`. If `trim` is true, elements in | |||
| /// the list which don't include Unicode coverage not provided by earlier elements in the list are elided. | |||
There was a problem hiding this comment.
Might be worth dropping a link to https://www.freedesktop.org/software/fontconfig/fontconfig-devel/fcfontsort.html here.
|
Thanks for the review, PTAL. |
wezm
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sort_fontsfunction (which internally callsFCFontSort) and anadd_integerfunction (which internally callsFCPatternAddInteger).list_fontsdoes not allow for sorting by closeness or trimming results from the font set if the an earlier font in the list already covers the same unicode range as a given font.