New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error messages for unique key #1531

Closed

parsonsmatt wants to merge 1 commit into master from mattp/fix-unique-key-error-messages

Collaborator

parsonsmatt commented Apr 29, 2024

Prior to this PR, you'd get a confusing type error message with the AtLeastOneUniqueKey class. This fixes it to properly refer to what'sgoing on.

Before submitting your PR, check that you've:

Documented new APIs with Haddock markup
Added @since declarations to the Haddock
Ran stylish-haskell on any changed files.
Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

Update the Changelog.md file with a link to your PR
Bumped the version number if there isn't an (unreleased) on the Changelog
Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)


          Fix type error messages

66bd932

parsonsmatt commented

View reviewed changes

persistent/Database/Persist/TH.hs

    
            @@ -2262,14 +2266,12 @@ mkUniqueKeyInstances :: MkPersistSettings -> UnboundEntityDef -> Q [Dec]
          
              mkUniqueKeyInstances mps entDef = do

                  requirePersistentExtensions

                  case entityUniques (unboundEntityDef entDef) of

                      [] -> mappend <$> typeErrorSingle <*> typeErrorAtLeastOne

                      [] -> mappend <$> mkOnlyUniqueError typeErrorNoneCtx <*> mkAtLeastOneUniqueError typeErrorNoneCtx

Collaborator Author

parsonsmatt Apr 29, 2024

Previously, typeErrorAtLeastOne would complain about having too many unique keys. Oops.

parsonsmatt closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet