Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This is just a test PR [DO NOT MERGE] #1787

Closed
wants to merge 2 commits into from
Closed

This is just a test PR [DO NOT MERGE] #1787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a2fa44
fix: gas diff test
JuArce Feb 10, 2025
43af23d
fix: update gas-diff version
JuArce Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/foundry-gas-diff.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ jobs:
FOUNDRY_FUZZ_SEED: 0x${{ github.event.pull_request.base.sha || github.sha }}

- name: Compare gas reports
uses: Rubilmax/foundry-gas-diff@v3.16
uses: Rubilmax/foundry-gas-diff@v3.21
with:
summaryQuantile: 0.9 # only display the 10% most significant gas diffs in the summary (defaults to 20%)
sortCriteria: avg,max # sort diff rows by criteria
Expand Down
4 changes: 2 additions & 2 deletions contracts/src/core/BatcherPaymentService.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ contract BatcherPaymentService is
event FundsWithdrawn(address indexed recipient, uint256 amount);
event BalanceLocked(address indexed user);
event BalanceUnlocked(address indexed user, uint256 unlockBlockTime);
event TaskCreated(bytes32 indexed batchMerkleRoot, uint256 feePerProof);
event TaskCreated(bytes32 indexed batchMerkleRoot, uint256 feePerProof, uint256 amountOfProofs);

// ERRORS
error OnlyBatcherAllowed(address caller); // 152bc288
Expand Down Expand Up @@ -132,7 +132,7 @@ contract BatcherPaymentService is
respondToTaskFeeLimit
);

emit TaskCreated(batchMerkleRoot, feePerProof);
emit TaskCreated(batchMerkleRoot, feePerProof, proofSubmittersQty);

payable(batcherWallet).transfer(
(feePerProof * proofSubmittersQty) - feeForAggregator
Expand Down