Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link url and orcid for authors in DESCRIPTION #62

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

TimTaylor
Copy link
Contributor

Initial poc for:

  • linking an authors name to their URL.
  • linking to ORCiD

@yihui - I'm marking this as draft for now but wanted to share before I go down an unnecessary rabbit holes.

Questions:

  1. I'm not very familiar with html/css so have hardcoded the same css that is used on CRAN. I guess you would want this moved elsewhere / handled differently but I'm not sure how you like to do this?
  2. I've bundled the svg (again the one used by CRAN) and currently it requires a user to have it in their site directory. I think it may be better to have the svg incorporated directly, e.g. <img src='data:image/svg+xml;utf8,<svg ... > ... </svg>'> but I was unable to get this working (likely due to my ignorance of html and css). If you think that would be a better approach let me know and I'll try again.

I probably can't look at this again for a couple of days, but let me know if you have thoughts comments and I'll update when I can (that said, feel free to pick this up and alter should you wish).

Initial poc for:
- linking an authors name to their URL.
- linking to ORCiD
@TimTaylor
Copy link
Contributor Author

TimTaylor commented Dec 16, 2024

I've noted that the check has failed because I'm using raw character constants (i.e. r"()" syntax). I'll update this as needed.

Copy link
Owner

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It looks like you have finished the majority of the work. I can pick it up from here and get it done in a few minutes.

yihui added a commit to yihui/lite.js that referenced this pull request Dec 16, 2024
@yihui yihui added the enhancement New feature or request label Dec 16, 2024
@yihui yihui marked this pull request as ready for review December 16, 2024 15:27
@yihui yihui merged commit cc34de8 into yihui:main Dec 16, 2024
14 checks passed
TimTaylor added a commit to TimTaylor/litedown that referenced this pull request Dec 16, 2024
yihui pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants