Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new widgets feature "theme config" #244

Merged
merged 23 commits into from
Nov 16, 2023
Merged

Adapt to new widgets feature "theme config" #244

merged 23 commits into from
Nov 16, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Feb 5, 2023

Q A
Is bugfix?
New feature?
Breaks BC? ✔️
Fixed issues -

config/params.php Outdated Show resolved Hide resolved
docs/creating-forms.md Outdated Show resolved Hide resolved
tests/ConfigTest.php Outdated Show resolved Hide resolved
src/Field.php Show resolved Hide resolved
src/ThemeDispatcher.php Outdated Show resolved Hide resolved
@vjik vjik changed the title Adapt to new widgets feature "default config" Adapt to new widgets feature "theme config" Mar 2, 2023
@vjik vjik marked this pull request as ready for review March 2, 2023 13:05
@vjik vjik requested a review from a team March 2, 2023 13:05
@vjik vjik added the status:code review The pull request needs review. label Mar 2, 2023
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e6861fd) 98.31% compared to head (b3054ff) 98.92%.

Files Patch % Lines
config/bootstrap.php 0.00% 1 Missing ⚠️
src/ThemeContainer.php 92.30% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #244      +/-   ##
============================================
+ Coverage     98.31%   98.92%   +0.61%     
+ Complexity      878      853      -25     
============================================
  Files            47       47              
  Lines          2614     2519      -95     
============================================
- Hits           2570     2492      -78     
+ Misses           44       27      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik merged commit bdfe924 into master Nov 16, 2023
23 checks passed
@vjik vjik deleted the new-widgets branch November 16, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants