Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use nested values for arrays and nulled objects #272

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 17, 2023

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #262

Copy link

what-the-diff bot commented Nov 17, 2023

PR Summary

  • Introduction of Fresh Exceptions
    New files have been introduced that enable the system to respond and handle various error situations better. These include scenarios where nested values aren't properly supported, there are issues with the properties of an object, a desired value is missing and more.

  • Augmentation of Form Attribute Handling
    The FormAttributeTrait.php, FormModel.php, FormModelInterface.php and HtmlForm.php files have been modified. This enhancement brought in better ways to manage and deal with form attribute values. Moreover, if issues arise while dealing with these values, they have implemented additional exception handling logic.

  • Upgraded Testing for Nested Structures in Forms
    There have been alterations made to InputFieldTest.php and FormModelTest.php, which introduced new tests and assertions. These have been designed to handle new changes associated with nested structures in forms.

  • Improved Support for Form and Coordinates Representation
    New attributes and classes have been incorporated in TextForm.php and Coordinates.php which are designed to provide better support and representation of forms and coordinates, respectively.

  • Creation of a Form Class to Handle Nested Structures
    A new form class with nested structures has been developed and added to FormWithNestedStructures.php, aiming at suitably dealing with intricate form structures.

  • Removal of Outdated Files
    The files UndefinedPropertyException.php, NonNamespacedForm.php and DynamicAttributesForm.php have been taken off as they are obsolete and no longer required in the system.

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dad3a5a) 98.92% compared to head (b2b2bf4) 98.93%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #272   +/-   ##
=========================================
  Coverage     98.92%   98.93%           
- Complexity      855      860    +5     
=========================================
  Files            48       51    +3     
  Lines          2521     2531   +10     
=========================================
+ Hits           2494     2504   +10     
  Misses           27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vjik vjik requested a review from a team November 17, 2023 15:12
@vjik vjik added the status:code review The pull request needs review. label Nov 17, 2023
@vjik vjik merged commit 08309c1 into master Nov 21, 2023
@vjik vjik deleted the allow-nested branch November 21, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants