Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add methods name() and value() for input fields #281

Merged
merged 4 commits into from
Nov 26, 2023
Merged

Add methods name() and value() for input fields #281

merged 4 commits into from
Nov 26, 2023

Conversation

vjik
Copy link
Member

@vjik vjik commented Nov 25, 2023

Q A
Is bugfix?
New feature? ✔️
Breaks BC? ✔️
Fixed issues #273

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5e485e3) 94.30% compared to head (14ba730) 94.32%.

Files Patch % Lines
src/Field/Base/InputData/FormModelInputData.php 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #281      +/-   ##
============================================
+ Coverage     94.30%   94.32%   +0.02%     
- Complexity      847      856       +9     
============================================
  Files            52       53       +1     
  Lines          2510     2537      +27     
============================================
+ Hits           2367     2393      +26     
- Misses          143      144       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Nov 25, 2023

PR Summary

  • Introduction of a new file CustomNameAndValueForInputDataTrait.php
    This new file has been added to improve data handling functionality in our application. It brings advanced capabilities for managing input data.

  • Enhancements in FormModelInputData.php, InputDataInterface.php, and PureInputData.php files
    Several properties and methods have been added to these files to increase their performance and versatility.

  • Application of CustomNameAndValueForInputDataTrait trait to multiple files
    The newly created CustomNameAndValueForInputDataTrait trait has been applied to various file handling components like InputField.php, CheckboxList.php, RadioList.php, and File.php. This allows our program to process input data in a more efficient and versatile way.

  • Removal of value method from File.php file
    This method was removed for optimization purposes. Its functions are now replaced by the new traits and methods added.

  • Addition of test cases in FileTest.php and TextTest.php files
    This ensures the new changes work as intended. This ensures the quality of our software by running a series of tests.

@vjik vjik added the status:code review The pull request needs review. label Nov 25, 2023
@vjik vjik requested a review from a team November 25, 2023 17:45
src/Field/Base/InputData/FormModelInputData.php Outdated Show resolved Hide resolved
src/Field/Base/InputData/FormModelInputData.php Outdated Show resolved Hide resolved
src/Field/Base/InputData/FormModelInputData.php Outdated Show resolved Hide resolved
src/Field/Base/InputData/FormModelInputData.php Outdated Show resolved Hide resolved
@vjik vjik merged commit 857d213 into master Nov 26, 2023
27 checks passed
@vjik vjik deleted the name-value branch November 26, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants