Add early returning for windows

yiisoft · Jun 24, 2024 · 997e046 · 997e046
1 parent 8789df6
commit 997e046
Showing 1 changed file with 10 additions and 0 deletions.
diff --git a/src/Command/Serve.php b/src/Command/Serve.php
@@ -132,6 +132,11 @@ protected function execute(InputInterface $input, OutputInterface $output): int
         }
 
         if ($this->isAddressTaken($address)) {
+            if ($this->isWindows()) {
+                $io->error("Port {$port} is taken by another process");
+                return self::EXIT_CODE_ADDRESS_TAKEN_BY_ANOTHER_PROCESS;
+            }
+
             $runningCommandPIDs = trim((string) shell_exec('lsof -ti :8080 -s TCP:LISTEN'));
             if (empty($runningCommandPIDs)) {
                 $io->error("Port {$port} is taken by another process");
@@ -273,4 +278,9 @@ private function getRootPath(): string
 
         return getcwd();
     }
+
+    private function isWindows(): bool
+    {
+        return stripos(PHP_OS, 'Win') === 0;
+    }
 }