Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #36: Remove yiisoft/view dependency #56

Merged
merged 9 commits into from
Oct 14, 2022
Merged

Fix #36: Remove yiisoft/view dependency #56

merged 9 commits into from
Oct 14, 2022

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ✔️
Fixed issues #36

@rustamwin rustamwin added the status:code review The pull request needs review. label Oct 10, 2022
@rustamwin rustamwin requested a review from a team October 10, 2022 17:55
@codecov
Copy link

codecov bot commented Oct 10, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d0f2425). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage          ?   44.57%           
  Complexity        ?      193           
=========================================
  Files             ?       12           
  Lines             ?      516           
  Branches          ?        0           
=========================================
  Hits              ?      230           
  Misses            ?      286           
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

arogachev
arogachev reviewed Oct 11, 2022
View reviewed changes
config/routes.php Outdated Show resolved Hide resolved
arogachev
arogachev reviewed Oct 12, 2022
View reviewed changes
src/CodeFile.php Outdated Show resolved Hide resolved
arogachev
arogachev reviewed Oct 12, 2022
View reviewed changes
config/routes.php Outdated Show resolved Hide resolved
arogachev
arogachev requested changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@arogachev arogachev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

What about tests?

@xepozz
Copy link
Member

xepozz commented Oct 13, 2022

Suggest not to do a lot of additional refactoring because I would do the #55 issue instead.

@xepozz xepozz merged commit 1d2d2bc into master Oct 14, 2022
@xepozz xepozz deleted the fix-36 branch October 14, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arogachev arogachev arogachev requested changes

@xepozz xepozz xepozz approved these changes

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
status:code review The pull request needs review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rustamwin @xepozz @samdark @arogachev @StyleCIBot