-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transaction support #276
base: master
Are you sure you want to change the base?
Transaction support #276
Conversation
Lisio
commented
May 25, 2019
Q | A |
---|---|
Is bugfix? | no |
New feature? | yes |
Breaks BC? | no |
Tests pass? | n/a |
Fixed issues |
Something wrong with the tests, current master also fails. |
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
Do we need to use version 1.1.8 of mongodb extension for php 5.5? Session parameter is only compatible with 1.4.0 which is compatible with php 5.5. |
No, we don't. Likely using |
But first, let's merge master into this branch... |
@Lisio tests seems to fail on 5.4. |
Testing environment fails to install correct version of mongodb library
|
Yeah :( Seems we need to do it manually: |