-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
better performance for exists() method of Query class #298
base: master
Are you sure you want to change the base?
Conversation
ziaratban
commented
Feb 15, 2020
•
edited
Loading
edited
Q | A |
---|---|
Is bugfix? | yes |
New feature? | no |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues | #290 |
@samdark what is milestone for this PR ? |
2.1.10. Overall it looks extremely hacky. Need @yiisoft/core-developers and @yiisoft/reviewers opinions about it. |
Some more explanation why this is better would be nice. Also test do not pass. |
@schmunk42 the explanation is in #290 |
How about
and do the modifications when |
@schmunk42 does it make sense to do it in non-optimized way? |
I am no mongo expert, my concern is only about BC. Counterquestion: Why is it not done by mongo, if it makes no difference? |
@samdark please see Checking if a document exists – MongoDB slow findOne vs find |
The link could be added to comment since the code there causes questions immediately. |