-
-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Ensure messages are consumed at least once. #516
base: master
Are you sure you want to change the base?
Conversation
Is there a way to test that? |
The host may crashed before`rpush` was executed
hi @samdark ,I need your help to review unit test code. |
Co-authored-by: Alexander Makarov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The tests are good now. One last thing — a line for CHANGELOG.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The tests are good now. One last thing — a line for CHANGELOG.
The host may crashed before
rpush
was executed