Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Ensure messages are consumed at least once. #516

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

noname007
Copy link

The host may crashed beforerpush was executed

Q A
Is bugfix? ✔️/❌
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues

@samdark samdark added the pr:request for unit tests Unit tests are needed. label May 23, 2024
@samdark
Copy link
Member

samdark commented May 23, 2024

Is there a way to test that?

@noname007
Copy link
Author

use debug mode and add some code to emulate the crash scenario
image

@noname007 noname007 changed the title at leat once msg consume Enhancement: Ensure messages are consumed at least once. Mar 2, 2025
@noname007
Copy link
Author

hi @samdark ,I need your help to review unit test code.

@samdark samdark requested review from a team March 3, 2025 10:02
@samdark samdark removed the pr:request for unit tests Unit tests are needed. label Mar 5, 2025
@samdark samdark self-assigned this Mar 5, 2025
noname007 and others added 2 commits March 6, 2025 11:58
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The tests are good now. One last thing — a line for CHANGELOG.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 The tests are good now. One last thing — a line for CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants