Temporal profile #17
Open
Temporal profile #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added gaussian pulse in addition to the single-frequency scheme. This would allow for broadband simulation, and together with phasor, allow for recording of multiple frequencies in the results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on the temporal profiles of sources. The changes include the introduction of new classes for temporal profiles and modifications to existing methods to utilize these profiles.
Key changes include:
Introduction of Temporal Profiles:
TemporalProfileand its implementationsSingleFrequencyProfileandGaussianPulseProfileto define how source amplitude varies in time. (src/fdtdx/objects/sources/source.py)Modifications to Source Class:
Sourceclass to include atemporal_profileattribute, which defines the time-dependent amplitude variation of the source. (src/fdtdx/objects/sources/source.py) [1] [2]Refactoring of Update Methods:
update_Emethod to use thetemporal_profilefor calculating the temporal amplitude of the H field. (src/fdtdx/objects/sources/plane_source.py)update_Hmethod to use thetemporal_profilefor calculating the temporal amplitude of the E field. (src/fdtdx/objects/sources/plane_source.py)