Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx Docs #17

Merged
merged 79 commits into from
Jul 19, 2024
Merged

Conversation

tweak-wtf
Copy link
Collaborator

@tweak-wtf tweak-wtf commented Jun 20, 2024

Description

This PR improves on docstrings, builds sphinx documentation and serves them on https://ynput.github.io/LabLib .

  • adds workflow for building the docs and hosts them on GH Pages by serving its static html on branch gh-pages
    • auto-compiles README.md to rst using pandoc

Testing Notes

  • workflow target branch should be changed to main before merging
  • steps to build docs:
    • run start.ps1 set-env
      • that's what the $PYTHONPATH is for, else the sphinx conf.py doesn't find lablib
    • cd .\docs\
    • poetry run make html
  • find html file in .\docs\_build\html\

closes #15

@tweak-wtf tweak-wtf changed the base branch from main to develop June 27, 2024 20:58
@tweak-wtf tweak-wtf linked an issue Jun 27, 2024 that may be closed by this pull request
@tweak-wtf tweak-wtf marked this pull request as ready for review June 27, 2024 21:20
@tweak-wtf tweak-wtf added the documentation Improvements or additions to documentation label Jun 27, 2024
@tweak-wtf
Copy link
Collaborator Author

i'm wondering whether i should already set up GitHub Actions for building the docs.
what do u say @jakubjezek001 ?

@@ -15,6 +15,7 @@ opentimelineio = "^0.16.0"
pytest = "^6.2.0"
opencolorio = "^2.3.2"
selenium = "^4.20.0"
sphinx = "^7.3.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could not resolve this with on windows with my poetry lock, but this is not a problem since once I had removed it it had been recreated again correctly.

- Added new Sphinx extensions and a custom theme for improved documentation appearance. Updated dependencies for documentation building.
@jakubjezek001
Copy link
Member

i'm wondering whether i should already set up GitHub Actions for building the docs. what do u say @jakubjezek001 ?

If you know how to, then lets do it! :D

@tweak-wtf
Copy link
Collaborator Author

i'm wondering whether i should already set up GitHub Actions for building the docs. what do u say @jakubjezek001 ?

If you know how to, then lets do it! :D

yeeees. was just waiting for ur go :D

docs/conf.py Outdated Show resolved Hide resolved
@jakubjezek001 jakubjezek001 self-requested a review July 19, 2024 08:10
jakubjezek001 and others added 2 commits July 19, 2024 13:27
Update typing in OCIO configuration file and ImageInfo class, add optional types. Refactor SlateHtmlGenerator into a plain Python class and add tests.
…-enhancement-docs-refactor

15 Refining Docstrings for Code API Enhancement
@tweak-wtf
Copy link
Collaborator Author

let's disable the type annotations in the built docs

@tweak-wtf
Copy link
Collaborator Author

lemme check out how to suggest formatting/linting issues with GH actions. i'll explore this on a different PR

@tweak-wtf tweak-wtf merged commit ab254f1 into develop Jul 19, 2024
2 checks passed
@jakubjezek001 jakubjezek001 deleted the 15-refining-docstrings-for-code-api-enhancement branch August 19, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refining Docstrings for Code API Enhancement
2 participants