Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aligning json data in published layout across DCCs #109

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

moonyuet
Copy link
Member

@moonyuet moonyuet commented Sep 23, 2024

Changelog Description

This PR is to align json data in published layout, so that the layout data can be loaded in different DCCs.
Resolve #108

Additional info

Not entirely supports for blender yet.
Test along with ynput/ayon-maya#74

Testing notes:

  1. Create Layout
  2. Publish Layout
  3. Load Layout in Maya, Unreal

@moonyuet moonyuet marked this pull request as draft September 23, 2024 09:54
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to publish the Layout it also got it integrated into DB but when trying to load it back while still been in the UE it fails to load properly with following error msg:

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_0.4.5-dev.1\ayon_core\tools\loader\models\actions.py", line 740, in _load_representations_by_loader
    load_with_repre_context(
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\addons\core_0.4.5-dev.1\ayon_core\pipeline\load\utils.py", line 325, in load_with_repre_context
    return loader.load(repre_context, name, namespace, options)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "c:\Work\REPO\ayon-unreal\client\ayon_unreal\plugins\load\load_layout.py", line 745, in load
    save_dir = hierarchy_dir_list[0] if create_sequences else asset_dir
               ~~~~~~~~~~~~~~~~~~^^^
IndexError: list index out of range

@LiborBatek
Copy link
Member

here Im enclosing the loading results:

Original layout published UE

image

once loaded back into UE:

Screenshot 2024-09-24 145742

and when loaded into Maya:

Screenshot 2024-09-24 151316

@LiborBatek
Copy link
Member

so it seems more of an transforms issues the loading didnt trigger any error messages tho...

@moonyuet
Copy link
Member Author

moonyuet commented Sep 24, 2024

so it seems more of an transforms issues the loading didnt trigger any error messages tho...

I can see that. Would fix it.

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to publish the Layout from UE and successfully load all assets it contains but the transforms differ from the UE.

Besides obvious mirror in X axis there are also differences in rotation

In UE:

Screenshot 2024-10-01 172722

and when loaded into Maya:

Screenshot 2024-10-01 172814

Note you can compare values in the scrnshots as the same asset been selected for comparison

@mkolar mkolar assigned moonyuet and unassigned LiborBatek Oct 1, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created new test scene for publishing the layout from UE (just to clarify why different asset positioning) as I have lost the former workfile so nevermind the differences between older testing rounds and this one.

Here is my UE layout (I have used that ayon-unreal PR for producing it as mentioned in the testing steps)

Screenshot 2024-10-02 143120

and when in maya>

Screenshot 2024-10-02 143147

The scene is correctly positioned but the rotations are lacking. check those scnrshots for comparison

@moonyuet moonyuet added the type: enhancement Improvement of existing functionality or minor addition label Oct 15, 2024
Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have produced new layout product in UE (for assurance) and it went smoothly....issue comes when loading into maya, all assets got in nicely but without any transforms...

image

I will also enclose a JSON for layout for isnpection:
QD_sh020_layoutMain_v002.json.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvement of existing functionality or minor addition
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aligning data in Extract Layout with the loaders across DCCs
2 participants