Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛂 認証情報付与形式の変更 #61

Merged
merged 2 commits into from
Feb 22, 2024

Conversation

Shion1305
Copy link
Member

@Shion1305 Shion1305 commented Feb 21, 2024

Property Value
Corresponding Issue #59
Assignee @Shion1305

PRで実装される機能

  • Tokenをクエリで付与することによる認証情報付与

認証の流れとしては以下。

  1. LINEで認証を行う
  2. LINEからcallbackエンドポイントが叩かれる
  3. backend側で情報を受け取り認証Tokenを生成
  4. Frontend /token にtokenクエリで認証Tokenをつけた状態でリダイレクトさせる
  5. Frontend側で受け取り、sessionStorageにPiniaで保存したのち、Home画面にリダイレクトさせる

レビューをお願いしたいポイント

フロントエンド側との連携を確認してほしい

対応するフロントエンドのPRは以下。
ynufes-tech/ynufes-mypage-frontend#40

@ynufes-tech ynufes-tech deleted a comment from codecov bot Feb 21, 2024
@Shion1305 Shion1305 linked an issue Feb 21, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (00accdb) 40.00% compared to head (31cb957) 40.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #61   +/-   ##
=======================================
  Coverage   40.00%   40.00%           
=======================================
  Files          20       20           
  Lines         970      970           
=======================================
  Hits          388      388           
  Misses        582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tomoyahiroe tomoyahiroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@Shion1305 Shion1305 merged commit cdf7276 into main Feb 22, 2024
5 checks passed
@Shion1305 Shion1305 deleted the change-auth-redirect-token-2402 branch February 22, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Authorizationの設定をset-cookieから変更
2 participants