Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golang / CIのバージョン更新 #70

Merged
merged 5 commits into from
Mar 11, 2024
Merged

Golang / CIのバージョン更新 #70

merged 5 commits into from
Mar 11, 2024

Conversation

Shion1305
Copy link
Member

@Shion1305 Shion1305 commented Feb 29, 2024

Property Value
Corresponding Issue #69
Assignee @Shion1305

Golang / ciのバージョン更新を行いました

レビューをお願いしたいポイント

setup-go をv5に更新したら
依存性をキャッシングできるようになって、
46秒CIの時間が短くなった!!!

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.51%. Comparing base (5e697ce) to head (48d21ce).

❗ Current head 48d21ce differs from pull request most recent head 53c31a7. Consider uploading reports for the commit 53c31a7 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #70       +/-   ##
===========================================
- Coverage   50.33%   23.51%   -26.82%     
===========================================
  Files          24      105       +81     
  Lines        1035     3661     +2626     
===========================================
+ Hits          521      861      +340     
- Misses        514     2800     +2286     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shion1305
Copy link
Member Author

setup-go のキャッシング機能に関するリファレンス
https://trap.jp/post/1655/
https://tech.yappli.io/entry/setup-go-v4

@Shion1305 Shion1305 self-assigned this Feb 29, 2024
Copy link
Collaborator

@tomoyahiroe tomoyahiroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shion1305 Shion1305 merged commit 2b417ec into main Mar 11, 2024
3 checks passed
@Shion1305 Shion1305 deleted the upgrade-go-1.22 branch March 11, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants