Revert of Move ChangeVersionWrapper destructor out of line. (patchset #1

id:1 of https://codereview.chromium.org/572343002/) Reason for revert: No longer needed, we fixed this in clang instead (see BUG=). Original issue's description: > Move ChangeVersionWrapper destructor out of line. > > With clang/win, the vtable of ChangeVersionWrapper ends up being referenced > for some reason, which causes the destructor to be defined, which requires > a definition of SQLErrorData. So move the destructor out of line, where > the definition is available. > > BUG=413478 > [email protected], [email protected] > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182093 [email protected],[email protected] NOTREECHECKS=true NOTRY=true BUG=413478 Review URL: https://codereview.chromium.org/563143005 git-svn-id: svn://svn.chromium.org/blink/trunk@182124 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss · Sep 17, 2014 · 6138335 · 6138335
1 parent 9befb1d
commit 6138335
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/Source/modules/webdatabase/ChangeVersionWrapper.cpp b/Source/modules/webdatabase/ChangeVersionWrapper.cpp
@@ -41,10 +41,6 @@ ChangeVersionWrapper::ChangeVersionWrapper(const String& oldVersion, const Strin
 {
 }
 
-ChangeVersionWrapper::~ChangeVersionWrapper()
-{
-}
-
 bool ChangeVersionWrapper::performPreflight(SQLTransactionBackend* transaction)
 {
     ASSERT(transaction && transaction->database());

diff --git a/Source/modules/webdatabase/ChangeVersionWrapper.h b/Source/modules/webdatabase/ChangeVersionWrapper.h
@@ -40,8 +40,6 @@ class ChangeVersionWrapper FINAL : public SQLTransactionWrapper {
 public:
     static PassRefPtrWillBeRawPtr<ChangeVersionWrapper> create(const String& oldVersion, const String& newVersion) { return adoptRefWillBeNoop(new ChangeVersionWrapper(oldVersion, newVersion)); }
 
-    virtual ~ChangeVersionWrapper();
-
     virtual void trace(Visitor* visitor) OVERRIDE { SQLTransactionWrapper::trace(visitor); }
     virtual bool performPreflight(SQLTransactionBackend*) OVERRIDE;
     virtual bool performPostflight(SQLTransactionBackend*) OVERRIDE;
-Original file line number
+Diff line change
@@ Expand Up @@
     {
     }
-    ChangeVersionWrapper::~ChangeVersionWrapper()
-    {
-    }
     bool ChangeVersionWrapper::performPreflight(SQLTransactionBackend* transaction)
     {
         ASSERT(transaction && transaction->database());
@@ Expand Down @@