Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Builtin notification system in reNgine #1392 #1394

Merged
merged 18 commits into from
Aug 31, 2024

Conversation

yogeshojha
Copy link
Owner

@yogeshojha yogeshojha commented Aug 31, 2024

This PR introduces a new in app notification within reNgine web page, for now for any scan related notification will be shown and also when there is any update in reNgine.

This notification bell will be visible in the dashboard, and will be rechecking for any new notification every 15 seconds.

If there is any new notification, a snackbar will also be shown.

Example of the in app notification in reNgine

image

Clearing all notification and marking them all read option is also provided.

A new generic function has been introduced, called create_inappnotification which can be used across reNgine to create notification

def create_inappnotification(
		title,
		description,
		notification_type=SYSTEM_LEVEL_NOTIFICATION,
		project_slug=None,
		icon="mdi-bell",
		is_read=False,
		status='info',
		redirect_link=None,
		open_in_new_tab=False
):

Copy link
Contributor

Woohoo @yogeshojha! 🎉 You've just dropped some hot new code! 🔥

Hang tight while we review this! You rock! 🤘

@yogeshojha yogeshojha merged commit 7b1e6e9 into release/2.2.0 Aug 31, 2024
2 checks passed
Copy link
Contributor

Holy smokes! 🤯 You've just made reNgine even more awesome!

Your code is now part of the reNgine hall of fame. 🏆

Keep the cool ideas coming - maybe next time you'll break the internet! 💻💥

Virtual high fives all around! 🙌

1 similar comment
Copy link
Contributor

Holy smokes! 🤯 You've just made reNgine even more awesome!

Your code is now part of the reNgine hall of fame. 🏆

Keep the cool ideas coming - maybe next time you'll break the internet! 💻💥

Virtual high fives all around! 🙌

@yogeshojha yogeshojha deleted the 1392-feat-builtin-notification-system branch September 14, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant