Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all remaining devDependencies #1713

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Update all remaining devDependencies #1713

merged 1 commit into from
Dec 28, 2024

Conversation

djahandarie
Copy link
Collaborator

Stacked on

This PR does all the remaining devDependencies but leaves normal dependencies for another PR, since those could potentially have user impact.

@djahandarie djahandarie added kind/meta The issue or PR is meta area/ci The issue or PR is related to continuous integration and/or continuous delivery labels Dec 28, 2024
@djahandarie djahandarie requested a review from a team as a code owner December 28, 2024 12:39
@djahandarie djahandarie added area/dependencies The issue or PR is related to dependencies and removed area/ci The issue or PR is related to continuous integration and/or continuous delivery labels Dec 28, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 28, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1713 will degrade performances by 33.93%

Comparing even-more-dependency-updates (134964a) with master (a0302f0)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

❌ 1 (👁 1) regressions
✅ 2 untouched benchmarks

Benchmarks breakdown

Benchmark master even-more-dependency-updates Change
👁 Translator.prototype.findKanji - (n=3) 2.8 ms 4.2 ms -33.93%

@djahandarie djahandarie mentioned this pull request Dec 28, 2024
Open
Base automatically changed from more-dependency-updates to master December 28, 2024 13:25
@djahandarie djahandarie mentioned this pull request Dec 28, 2024
Closed
@djahandarie djahandarie force-pushed the even-more-dependency-updates branch from 4b5c33c to 134964a Compare December 28, 2024 14:14
@djahandarie djahandarie added this pull request to the merge queue Dec 28, 2024
Merged via the queue into master with commit fd577b8 Dec 28, 2024
13 checks passed
@djahandarie djahandarie deleted the even-more-dependency-updates branch December 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarvNC MarvNC MarvNC approved these changes

Assignees
No one assigned
Labels
area/dependencies The issue or PR is related to dependencies kind/meta The issue or PR is meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@djahandarie @MarvNC