Make sanitizer fail entirely on any errors #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Casheeew
approved these changes
Jan 1, 2025
djahandarie
approved these changes
Jan 1, 2025
|
Hmm, something unusual seems to have happened in the playwright logs. I can't access the report right now, could you take a look? Not sure if I broke something in my most recent PR for playwright. |
|
It looks like I broke the comment action: https://github.com/yomidevs/yomitan/actions/runs/12565357077/job/35029525823#step:8:1 I think this PR actually failed playwright for some reason 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the supported versions for this wrong in #1722. This check should not be needed.