Allow dictionaries to specify minimum compatible Yomitan version #1750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djahandarie
reviewed
Jan 9, 2025
| if (typeof minimumYomitanVersion === 'string') { | ||
| if (details.yomitanVersion === '0.0.0.0') { | ||
| // Running a development version of Yomitan | ||
| } else if (compareRevisions(details.yomitanVersion, minimumYomitanVersion)) { |
There was a problem hiding this comment.
Was chrome.runtime not available in this context, or was the purpose of calling it where you did a performance optimization?
There was a problem hiding this comment.
Yes, not available. I initially tried to use chrome.runtime here within the DictionaryImporter class, but it caused an error (ReferenceError: chrome is not defined).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1506
My solution for passing the current Yomitan version from the runtime manifest to the dictionary importer might be a little awkward. Other than that, I've tested this and it works fine.