-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all instances of yomichan #314
Conversation
View Playwright Report (note: open the "playwright-report" artifact) |
just noting the playwright tests didn't actually fail - it's just detecting the title of the test page changing to yomitan |
This PR replaces (to my knowledge) every instance of
yomichan
toyomitan
in the project (that is necessary). I ran the tests and they gave back no errors. I did a little testing and everything seems to work.Some things to note:
TypeError: Dexie is not a constructor
).Errors
tab in chrome extensions, it gives an Uncaught SyntaxError: Cannot use import statement outside a module, and linksjs/language/text-scanner.js:19 (anonymous function)
. Don't really know what this means...templates.md
, I changed the handlebars examples to yomitan. For example,{{~concat "yomitan_" (get "index") "_value"}}
. I'm not sure if this is intended and if it is correct in the code.If I did something wrong, please tell me, as this is my first time making a PR of this size...
(also the participant aiborii is just me, I think I messed with git a bit...)