Automate generation of legal information for dependencies #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themoeway-bot
previously approved these changes
Nov 22, 2023
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
force-pushed
the
automate-legal
branch
from
8ab6260 to
d682722
Compare
themoeway-bot
previously approved these changes
Nov 23, 2023
djahandarie
force-pushed
the
automate-legal
branch
from
d682722 to
dd82732
Compare
themoeway-bot
previously approved these changes
Nov 23, 2023
djahandarie
force-pushed
the
automate-legal
branch
from
dd82732 to
ae2f6cb
Compare
themoeway-bot
previously approved these changes
Nov 23, 2023
djahandarie
force-pushed
the
automate-legal
branch
from
ae2f6cb to
6f6aa2f
Compare
themoeway-bot
previously approved these changes
Nov 23, 2023
djahandarie
force-pushed
the
automate-legal
branch
from
6f6aa2f to
b5c788b
Compare
themoeway-bot
previously approved these changes
Nov 23, 2023
djahandarie
force-pushed
the
automate-legal
branch
from
b5c788b to
5c4e521
Compare
themoeway-bot
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a bit unclear to me if it's okay to not have the full LICENSE of each dependency vendored into
legal.html, but this method (which only includes the license name and a link) seems much nicer, easier on developers/maintainers, and more likely to stay accurate as we update dependency versions etc.The html is generated in CI. The README markdown is still semi-manual (need to run the command and insert it into the README yourself currently).