rename variables #409

Casheeew · 2023-12-20T08:23:57Z

Unclear names are renamed.
Names that only differ by a number identifier at the end are renamed.
- Those where the variants lives only in a limited scope, and lives to distinguish with the variable from the outer scope is kept. e.g) https://github.com/themoeway/yomitan/blob/8b943cc97fab890085448122e7c13dd035d0e238/dev/dictionary-validate.js#L49-L53
- those where the variants have equal functionality is kept. e.g) https://github.com/themoeway/yomitan/blob/8b943cc97fab890085448122e7c13dd035d0e238/ext/js/data/sandbox/string-util.js#L64-L71
- Internal functions that call another internal function with the same name is renamed to (*)Wrapper.

github-actions · 2023-12-20T08:26:45Z

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Casheeew · 2023-12-21T08:54:02Z

@djahandarie shouldn't this be tagged as kind/meta?

rename variables

0590183

Casheeew requested a review from a team as a code owner December 20, 2023 08:23

Casheeew marked this pull request as draft December 20, 2023 08:34

Casheeew added 3 commits December 20, 2023 17:40

add comment to ambiguous variable

96321b1

rename variables

4085f3b

add comments

d8f20bd

Casheeew marked this pull request as ready for review December 20, 2023 10:53

Casheeew marked this pull request as draft December 20, 2023 10:55

rename functions

589db58

Casheeew marked this pull request as ready for review December 20, 2023 11:29

djahandarie approved these changes Dec 20, 2023

View reviewed changes

djahandarie added this pull request to the merge queue Dec 20, 2023

Merged via the queue into yomidevs:master with commit 229f04b Dec 20, 2023
5 checks passed

Casheeew deleted the development branch December 21, 2023 01:01

djahandarie added the kind/meta The issue or PR is meta label Dec 21, 2023

Provide feedback