Dictionary data tests + write mode #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
djahandarie
approved these changes
Dec 22, 2023
This was referenced Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors and organizes the tests related to dictionary data. anki-note-builder.test.js and translator.test.js have been merged into a single file, as they share the same inputs.
dictionary.test.js has been renamed to dictionary-data-validate.test.js and refactored a bit.
This change also adds a test that writes the output files, which can be used by running
npm run test-code-write. This resolves point 2 in this issue and can be used to regenerate the new data in #359. This is currently done by still using vitest infrastructure, since it makes it so we don't have to write more code for instantiating the simulated web context.