fix: position in fromJSON does not work correctly (#392)

yomotsu · Mar 16, 2023 · 4fb31a0 · 4fb31a0
1 parent cd3f452
commit 4fb31a0
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/CameraControls.ts b/src/CameraControls.ts
@@ -2600,7 +2600,6 @@ export class CameraControls extends EventDispatcher {
 	fromJSON( json: string, enableTransition: boolean = false ): void {
 
 		const obj = JSON.parse( json );
-		const position = _v3A.fromArray( obj.position );
 
 		this.enabled               = obj.enabled;
 
@@ -2625,7 +2624,7 @@ export class CameraControls extends EventDispatcher {
 		this._focalOffset0.fromArray( obj.focalOffset0 );
 
 		this.moveTo( obj.target[ 0 ], obj.target[ 1 ], obj.target[ 2 ], enableTransition );
-		_sphericalA.setFromVector3( position.sub( this._targetEnd ).applyQuaternion( this._yAxisUpSpace ) );
+		_sphericalA.setFromVector3( _v3A.fromArray( obj.position ).sub( this._targetEnd ).applyQuaternion( this._yAxisUpSpace ) );
 		this.rotateTo( _sphericalA.theta, _sphericalA.phi, enableTransition );
 		this.zoomTo( obj.zoom, enableTransition );
 		this.setFocalOffset( obj.focalOffset[ 0 ], obj.focalOffset[ 1 ], obj.focalOffset[ 2 ], enableTransition );