Changed copy with move in writeXcodeProject. Resolves #1409 #1410
Conversation
Sources/XcodeGenKit/FileWriter.swift
Outdated
| @@ -16,12 +16,11 @@ public class FileWriter { | |||
| let tempPath = try Path.processUniqueTemporary() + "XcodeGen" | |||
| try? tempPath.delete() | |||
| if projectPath.exists { | |||
| try projectPath.copy(tempPath) | |||
| try projectPath.move(tempPath) | |||
There was a problem hiding this comment.
If the project is open, this would yank the project file out from underneath Xcode, which would complain no?
There was a problem hiding this comment.
Thank you for your concern! I've tested the changes multiple times, as I mentioned in the issue description, both by using the scheme preAction and from the terminal. It appears that there are no issues with the project file in my environment, and I haven't encountered any complains in Xcode. If you have specific test cases or scenarios in mind that you'd like me to investigate, please feel free to share them!
If you think it can be dangerous and you have any other idea or solution please tell me, because with this copy it also doesn't work properly
|
Any luck with this one @arkonxu? I don't have any tips, but I do have the frustration of how Xcode chooses to resolve swift packages when the project changes, and have always wondered if there was a way around that. |
Just changed copy with move in FileWrite: writeXcodeProject in order to fix an issue that I opened before:
https://github.com/yonaskolb/XcodeGen/issues/1409