Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover istanbul-instrumenter-loader to use debugger #659

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

hackerwins
Copy link
Member

@hackerwins hackerwins commented Sep 27, 2023

What this PR does / why we need it?

Previously, we replaced istanbul-instrumenter-loader with
coverage-istanbul-loader to address critical vulnerabilities.
However, this change resulted in improper line positioning within the
debugger.

To resolve this issue, this commit reverts back to using
istanbul-instrumenter-loader.

Additionally, in the future, we plan to replace the Karma-based test
runner with vitest.

Any background context you want to provide?

What are the relevant tickets?

Fixes #657
Related to #630 and #655

Checklist

  • Added relevant tests or not required
  • Didn't break anything

Sorry, something went wrong.

Previously, we replaced istanbul-instrumenter-loader with
coverage-istanbul-loader to address critical vulnerabilities.
However, this change resulted in improper line positioning within the
debugger.

To resolve this issue, this commit reverts back to using
istanbul-instrumenter-loader.

Additionally, in the future, we plan to replace the Karma-based test
runner with vitest.
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (0fcc07f) 89.16% compared to head (b63cd15) 89.16%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #659   +/-   ##
=======================================
  Coverage   89.16%   89.16%           
=======================================
  Files          79       79           
  Lines        9318     9318           
  Branches      856      856           
=======================================
  Hits         8308     8308           
  Misses        697      697           
  Partials      313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hackerwins hackerwins merged commit df38c91 into main Sep 27, 2023
@hackerwins hackerwins deleted the revert-istanbul branch September 27, 2023 07:05
Copy link
Member

@blurfx blurfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

debugger is not positioned properly
2 participants