-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change base image to Debian 11 #2009
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d6ba12
to
d968e22
Compare
dd1a2d6
to
f5e8a8d
Compare
fca64be
to
36bc556
Compare
b108971
to
0b4e7ca
Compare
starboard/tools/api_leak_detector/stub/debug/gn_built_docker_debian11_manifest
Outdated
Show resolved
Hide resolved
This updates base runner images to Debian11. Also update leak check manifests to match. b/312772759
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2009 +/- ##
==========================================
+ Coverage 58.41% 59.28% +0.87%
==========================================
Files 1902 1711 -191
Lines 94709 78442 -16267
==========================================
- Hits 55325 46506 -8819
+ Misses 39384 31936 -7448 ☔ View full report in Codecov by Sentry. |
I believe this can go in, but then still need to re-land go/cobalt-cl/260221 ( now go/cobalt-cl/274780 ) |
andrewsavage1
approved these changes
Feb 6, 2024
sherryzy
pushed a commit
to sherryzy/cobalt
that referenced
this pull request
Feb 7, 2024
This updates base runner images to Debian11. b/291067151 b/291066320 b/312772759 b/321746394 (cherry picked from commit a37421c)
sherryzy
pushed a commit
to sherryzy/cobalt
that referenced
this pull request
Feb 21, 2024
This updates base runner images to Debian11. b/291067151 b/291066320 b/312772759 b/321746394 (cherry picked from commit a37421c)
sherryzy
added a commit
that referenced
this pull request
Feb 21, 2024
This updates base runner images to Debian11. b/291067151 b/291066320 b/312772759 b/321746394 (cherry picked from commit a37421c) Co-authored-by: Kaido Kert <[email protected]>
dahlstrom-g
pushed a commit
that referenced
this pull request
Feb 6, 2025
VCM used VideoCaptureController raw pointers in a number of places, including as a field in VCM::CaptureDeviceStartRequest. This CL replaces the field and some other usages with a scoped_refptr to prevent dangling pointers. (cherry picked from commit 3524ce528548d1d743a6aa6e339ecb5a186c22bc) Bug: 382135228 Change-Id: I1bd5f95bdf57631227034beb8bb076f258606378 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6088073 Commit-Queue: Guido Urdaneta <[email protected]> Reviewed-by: Dale Curtis <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#1396301} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6099792 Reviewed-by: Guido Urdaneta <[email protected]> Commit-Queue: Gyuyoung Kim (xWF) <[email protected]> Cr-Commit-Position: refs/branch-heads/6478@{#2009} Cr-Branched-From: e6143acc03189c5e52959545b110d6d17ecd5286-refs/heads/main@{#1300313}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates base runner images to Debian11.
b/312772759