Android blacboxtests fix, workaround for Python webdriver #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaidokert
force-pushed
the
android_tests
branch
2 times, most recently
from
3d79e55 to
926ae93
Compare
kaidokert
changed the title
This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704
kaidokert
force-pushed
the
android_tests
branch
from
926ae93 to
6bd8925
Compare
gbournou
approved these changes
Dec 29, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2140 +/- ##
==========================================
+ Coverage 58.54% 58.56% +0.02%
==========================================
Files 1912 1912
Lines 94578 94578
==========================================
+ Hits 55370 55392 +22
+ Misses 39208 39186 -22 ☔ View full report in Codecov by Sentry. |
kaidokert
added
cp-24.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 (cherry picked from commit 0f56fd5)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Jan 2, 2024
This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 (cherry picked from commit 0f56fd5)
kaidokert
added a commit
that referenced
this pull request
Jan 2, 2024
This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 (cherry picked from commit 0f56fd5)
kaidokert
added a commit
that referenced
this pull request
Jan 2, 2024
This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 (cherry picked from commit 0f56fd5)
kaidokert
added a commit
that referenced
this pull request
Jan 2, 2024
… webdriver (#2150) Refer to the original PR: #2140 This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 Co-authored-by: Kaido Kert <[email protected]>
kaidokert
added a commit
that referenced
this pull request
Jan 3, 2024
… webdriver (#2151) Refer to the original PR: #2140 This makes sure that Webdriver Remote connection is initialized with a timeout value before the timeout value gets used. Avoids errors coming from incompatible urrlib/request/webdriver packages using different global timeout values. b/318024704 Co-authored-by: Kaido Kert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that Webdriver Remote connection is initialized
with a timeout value before the timeout value gets used. Avoids
errors coming from incompatible urrlib/request/webdriver packages
using different global timeout values.
b/318024704