Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precommit metadata checks #2148

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Conversation

kaidokert
Copy link
Member

@kaidokert kaidokert commented Jan 2, 2024

This check always runs for all modified files, and delegates
further filtering to the invoked script.
pre-commit exclude: filtering cannot be used here currently,
as it does not support multiple filters or overriding globals.

b/150775273

@kaidokert kaidokert requested a review from briantting January 2, 2024 18:58
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a39034) 58.54% compared to head (5831c37) 58.54%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2148   +/-   ##
=======================================
  Coverage   58.54%   58.54%           
=======================================
  Files        1911     1911           
  Lines       94585    94585           
=======================================
+ Hits        55371    55374    +3     
+ Misses      39214    39211    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaidokert kaidokert requested a review from oxve January 2, 2024 21:14
@kaidokert kaidokert marked this pull request as ready for review January 2, 2024 21:47
@kaidokert kaidokert requested a review from dahlstrom-g January 2, 2024 21:48
This check always runs for all modified files, and delegates
further filtering to the invoked script.
pre-commit exclude: filtering cannot be used here currently,
as it does not support multiple filters or overriding globals.

b/150775273
@kaidokert kaidokert merged commit 7ae5706 into youtube:main Jan 2, 2024
332 checks passed
@dahlstrom-g
Copy link
Contributor

I was going to suggest using the commit 5831c37 title
“Add precommit check for METADATA files”
as the PR title which also becomes a commit title on submission.
https://cbea.ms/git-commit/#imperative

@kaidokert kaidokert deleted the precommit_meta branch June 30, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants