-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Ozone prototype commits into main #4727
Merged
madhurajayaraman
merged 7 commits into
youtube:main
from
madhurajayaraman:ozone-to-main
Jan 27, 2025
Merged
Merge Ozone prototype commits into main #4727
madhurajayaraman
merged 7 commits into
youtube:main
from
madhurajayaraman:ozone-to-main
Jan 27, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TyHolc
requested changes
Jan 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a few hacks left in there. Some might be removable with the move to Angle, but do we want to merge the others over?
Also in a couple spots we should put TODO comments to make sure we revisit those sections.
…outube#4654) This reverts commit cc55e87.
…ube#4688) Move ownership of SbWindow to PlatformWindowStarboard, allowing us to get the proper initialization size and assign it as the platform window in the platform window delegate. b/388348504
Swap to using Angle instead of native GLES to avoid devel/debug builds crashing. b/390499263
Mappings from kSbKeyFoo to ui::DomCode::Bar .
Remove starboard helper test class and instead run tests from the starboard thread itself. b/388348504
Surround remaining Cobalt hacks with the new Cobalt hack buildflag so they're easier to track and clean up later. b/391414243
madhurajayaraman
force-pushed
the
ozone-to-main
branch
from
January 27, 2025 17:53
6765c67
to
f54806e
Compare
y4vor
approved these changes
Jan 27, 2025
andrewsavage1
approved these changes
Jan 27, 2025
TyHolc
approved these changes
Jan 27, 2025
andrewsavage1
pushed a commit
to andrewsavage1/cobalt
that referenced
this pull request
Jan 27, 2025
Had weird merge conflicts in youtube#4726 so cherry-picked relevant changes instead. b/391414243 --------- Co-authored-by: Tyler Holcombe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had weird merge conflicts in #4726 so cherry-picked relevant changes instead.
b/391414243