Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Ozone prototype commits into main #4727

Merged
merged 7 commits into from
Jan 27, 2025

Conversation

madhurajayaraman
Copy link
Contributor

@madhurajayaraman madhurajayaraman commented Jan 21, 2025

Had weird merge conflicts in #4726 so cherry-picked relevant changes instead.

b/391414243

@madhurajayaraman madhurajayaraman requested a review from a team as a code owner January 21, 2025 19:32
Copy link
Contributor

@TyHolc TyHolc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few hacks left in there. Some might be removable with the move to Angle, but do we want to merge the others over?

Also in a couple spots we should put TODO comments to make sure we revisit those sections.

gpu/config/gpu_util.cc Outdated Show resolved Hide resolved
gpu/config/gpu_util.cc Outdated Show resolved Hide resolved
starboard/shared/linux/system_network_status.cc Outdated Show resolved Hide resolved
ui/ozone/platform/starboard/BUILD.gn Show resolved Hide resolved
ui/ozone/platform/starboard/platform_screen_starboard.cc Outdated Show resolved Hide resolved
TyHolc and others added 7 commits January 27, 2025 09:44
…ube#4688)

Move ownership of SbWindow to PlatformWindowStarboard, allowing us to
get the proper initialization size and assign it as the platform window
in the platform window delegate.

b/388348504
Swap to using Angle instead of native GLES to avoid devel/debug builds
crashing.

b/390499263
Mappings from kSbKeyFoo to ui::DomCode::Bar .
Remove starboard helper test class and instead run tests from the
starboard thread itself.

b/388348504
Surround remaining Cobalt hacks with the new Cobalt hack buildflag so
they're easier to track and clean up later.

b/391414243
@madhurajayaraman madhurajayaraman merged commit 086ff4b into youtube:main Jan 27, 2025
87 of 88 checks passed
andrewsavage1 pushed a commit to andrewsavage1/cobalt that referenced this pull request Jan 27, 2025
Had weird merge conflicts in youtube#4726
so cherry-picked relevant changes instead.

b/391414243

---------

Co-authored-by: Tyler Holcombe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants