Avoid redundant player bounds setting #4758
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
reviewed
Jan 24, 2025
Comment on lines
352
to
355
| int x_ = 0; | ||
| int y_ = 0; | ||
| int width_ = 0; | ||
| int height_ = 0; |
There was a problem hiding this comment.
Consider initializing them to -1, so {0, 0, 0, 0} will lead to a setVideoSurfaceBounds() call instead being skipped.
| @@ -326,7 +326,17 @@ class VideoDecoder::Sink : public VideoDecoder::VideoRendererSink { | |||
| render_cb_ = render_cb; | |||
| } | |||
|
|
|||
| void SetBounds(int z_index, int x, int y, int width, int height) override {} | |||
| void SetBounds(int z_index, int x, int y, int width, int height) override { | |||
| if (x_ != x || y != y_ || width != width_ || height != height_) { | |||
There was a problem hiding this comment.
Consider doing this above Starboard, otherwise the same has to be done for all 3P platforms.
jasonzhangxx
force-pushed
the
player-set-bounds
branch
from
8393365 to
5a57b28
Compare
1. Only change player bounds when there's a change. 2. Change Surface bounds from VideoRendererSink instead of hacking codde in SbPlayerSetBounds(). b/377754564
jasonzhangxx
force-pushed
the
player-set-bounds
branch
from
5a57b28 to
1c8a7b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/377754564