Migrate class MediaCodecBridge$GetOutputFormatResult to jni_generator #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haozheng-cobalt
force-pushed
the
jni-media-0
branch
3 times, most recently
from
bf1e906 to
b69359b
Compare
xiaomings
reviewed
Jan 24, 2025
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Outdated
Show resolved
Hide resolved
johnxwork
reviewed
Jan 24, 2025
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Show resolved
Hide resolved
cobalt/android/apk/app/src/main/java/dev/cobalt/media/MediaCodecBridge.java
Outdated
Show resolved
Hide resolved
haozheng-cobalt
force-pushed
the
jni-media-0
branch
2 times, most recently
from
4d6d127 to
40c78ea
Compare
haozheng-cobalt
force-pushed
the
jni-media-0
branch
from
40c78ea to
6a57ed4
Compare
haozheng-cobalt
changed the title
johnxwork
approved these changes
Jan 25, 2025
andrewsavage1
pushed a commit
to andrewsavage1/cobalt
that referenced
this pull request
Jan 27, 2025
…youtube#4759) This PR demonstrates jni_generator/jni_zero migration in cobalt/media. This PR primarily migrates the subclass GetOutputFormatResult in class MediaCodecBridge. I also have to migrate every native function in class MediaCodecBridge in this same PR because the old native implementations conflict with jni_generator; The jni header generated by jni_generator cobalt/android/jni_headers/MediaCodecBridge_jni.h would generate duplicated native function signatures as the old native implementations. Local tests: Call Native functions in Java: https://paste.googleplex.com/6062051978641408 Call Java functions in Native: https://paste.googleplex.com/6124614082887680 b/390481510
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates jni_generator/jni_zero migration in cobalt/media.
This PR primarily migrates the subclass GetOutputFormatResult in class MediaCodecBridge.
I also have to migrate every native function in class MediaCodecBridge in this same PR because the old native implementations conflict with jni_generator; The jni header generated by jni_generator cobalt/android/jni_headers/MediaCodecBridge_jni.h would generate duplicated native function signatures as the old native implementations.
Local tests:
Call Native functions in Java: https://paste.googleplex.com/6062051978641408
Call Java functions in Native: https://paste.googleplex.com/6124614082887680
b/390481510