-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package Cobalt for Linux #4760
Package Cobalt for Linux #4760
Conversation
Issue: 365150653 Reviewed-on: youtube#4760
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please factor in the feedback.
Also wrap the execution into a function, invoked by block
if __name__ == "__main__":
...
See Python style guide as to why: https://google.github.io/styleguide/pyguide.html#317-main
We generally follow Google Python style guide, with Chromium one taking precedence where applicable https://chromium.googlesource.com/chromium/src/+/main/styleguide/python/python.md
I do agree with following a style guide; I'll keep that in mind. |
Issue: 365150653 Reviewed-on: youtube#4760
Issue: 365150653 Reviewed-on: youtube#4760
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now for a first pass, to get things moving
Issue: 365150653