Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Cobalt for Linux #4760

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Package Cobalt for Linux #4760

merged 1 commit into from
Jan 28, 2025

Conversation

dahlstrom-g
Copy link
Contributor

Issue: 365150653

dahlstrom-g added a commit to dahlstrom-g/cobalt that referenced this pull request Jan 24, 2025
Issue: 365150653
Reviewed-on: youtube#4760
cobalt/devinfra/kokoro/build/linux/package.py Outdated Show resolved Hide resolved
cobalt/devinfra/kokoro/build/linux/package.py Outdated Show resolved Hide resolved
cobalt/devinfra/kokoro/build/linux/package.py Outdated Show resolved Hide resolved
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please factor in the feedback.

Also wrap the execution into a function, invoked by block

if __name__ == "__main__":
   ...

See Python style guide as to why: https://google.github.io/styleguide/pyguide.html#317-main

We generally follow Google Python style guide, with Chromium one taking precedence where applicable https://chromium.googlesource.com/chromium/src/+/main/styleguide/python/python.md

@dahlstrom-g
Copy link
Contributor Author

https://google.github.io/styleguide/pyguide.html#317-main

I do agree with following a style guide; I'll keep that in mind.
Pragmatically though have we had problems with people
trying to import our similar Python scripts as modules?

dahlstrom-g added a commit to dahlstrom-g/cobalt that referenced this pull request Jan 28, 2025
Issue: 365150653
Reviewed-on: youtube#4760
@dahlstrom-g dahlstrom-g requested review from oxve and kaidokert January 28, 2025 18:00
Issue: 365150653
Reviewed-on: youtube#4760
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm now for a first pass, to get things moving

@briantting briantting merged commit 1b4f3c1 into youtube:main Jan 28, 2025
87 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants