Add VideoGeometrySetter Service for Cobalt #4810
Open
+541
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borongc
force-pushed
the
sbplayer_bounds
branch
10 times, most recently
from
1cdc360 to
20fc77f
Compare
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Feb 4, 2025
Copy chromecast::media::VideoGeometrySetterService to Cobalt folder, as this is needed for youtube#4810. The PR doesn't have any functional changes. b/391938746
borongc
force-pushed
the
sbplayer_bounds
branch
2 times, most recently
from
b67c02b to
5bd4dcf
Compare
borongc
force-pushed
the
sbplayer_bounds
branch
from
5bd4dcf to
d9c3095
Compare
borongc
added a commit
to borongc/cobalt
that referenced
this pull request
Feb 5, 2025
Copy chromecast::media::VideoGeometrySetterService to Cobalt folder, as this is needed for youtube#4810. The PR doesn't have any functional changes. b/391938746
borongc
force-pushed
the
sbplayer_bounds
branch
from
d9c3095 to
0497eb9
Compare
yell0wd0g
reviewed
Feb 5, 2025
| @@ -83,10 +84,17 @@ blink::UserAgentMetadata GetCobaltUserAgentMetadata() { | |||
| return metadata; | |||
| } | |||
|
|
|||
| CobaltContentBrowserClient::CobaltContentBrowserClient() = default; | |||
| CobaltContentBrowserClient::CobaltContentBrowserClient() { | |||
| render_process_observer_.reset(new CobaltRenderProcessObserver()); | |||
There was a problem hiding this comment.
I thinksthis CL is not ready for review, but JIC nit: prefer std::make_unique<> instead of new:
There was a problem hiding this comment.
This follows CobaltWebContentsObserver, should we put all of them to std::make_unique<>?
borongc
added a commit
that referenced
this pull request
Feb 5, 2025
Copy chromecast::media::VideoGeometrySetterService to Cobalt folder, as this is needed for #4810. The PR doesn't have any functional changes. b/391938746
borongc
force-pushed
the
sbplayer_bounds
branch
5 times, most recently
from
96701d6 to
c3b20c0
Compare
StarboardRender needs to be informed with the video geometry information from the display compositor. VideoGeometrySetter provides the IPC between the StarobardRenderer and the display compositor so the video geometry information can reach StarboardRenderer. This is from https://chromium-review.googlesource.com/c/chromium/src/+/1799692. b/391938746
borongc
force-pushed
the
sbplayer_bounds
branch
from
c3b20c0 to
d4d4d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StarboardRender needs to be informed with the video geometry information from the display compositor. VideoGeometrySetter provides the IPC between the StarobardRenderer and the display compositor so the video geometry information can reach StarboardRenderer.
This refers to https://chromium-review.googlesource.com/c/chromium/src/+/1799692 with the following modifications:
This CL also cleans up the old implementations for setting video bounds: #4385, because it is unnecessary with this PR.
b/391938746