Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SbPlayerGetMediaTimeTest with e/ac3 audio #4835

Open
wants to merge 1 commit into
base: 25.lts.1+
Choose a base branch
from
+4 −9
Open

Fix SbPlayerGetMediaTimeTest with e/ac3 audio #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions starboard/android/shared/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,10 +89,6 @@

# TODO: b/280432564 Make this test work on lab devices consistently.
'SbAudioSinkTest.ContinuousAppend',

# TODO: b/347961880 Disable this test due to fail on e/ac3 audio format.
'SbPlayerGetMediaTimeTests/SbPlayerGetMediaTimeTest.TimeAfterSeek/*ec3*',
'SbPlayerGetMediaTimeTests/SbPlayerGetMediaTimeTest.TimeAfterSeek/*ac3*',
],
}
# pylint: enable=line-too-long
Expand Down
6 changes: 4 additions & 2 deletions starboard/nplb/player_get_media_time_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,11 @@ TEST_P(SbPlayerGetMediaTimeTest, TimeAfterSeek) {
const int64_t kDurationToPlay = 1'000'000; // 1 second
samples = GroupedSamples();
if (player_fixture.HasAudio()) {
int start_index =
player_fixture.ConvertDurationToAudioBufferCount(seek_to_time);
samples.AddAudioSamples(
0,
player_fixture.ConvertDurationToAudioBufferCount(seek_to_time) +
start_index,
start_index +
player_fixture.ConvertDurationToAudioBufferCount(kDurationToPlay));
samples.AddAudioEOS();
}
Expand Down
3 changes: 0 additions & 3 deletions starboard/win/win32/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,6 @@

# Enable once verified on the platform.
'SbMediaCanPlayMimeAndKeySystem.MinimumSupport',

# TODO: b/349109647 Disable flaky test.
'SbPlayerGetMediaTimeTests/*',
],
'player_filter_tests': [
# These tests fail on our VMs for win-win32 builds due to missing
Expand Down
Loading