Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send update view for the post #175

Merged
merged 9 commits into from
Apr 5, 2024

Conversation

ravi-sawlani-yral
Copy link
Contributor

Changes

  • send watch count and watch percentage for the video.

src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@rupansh-sekar-yral rupansh-sekar-yral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good,
mostly nitpicks are left

src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
src/page/post_view/video_loader.rs Outdated Show resolved Hide resolved
@ravi-sawlani-yral ravi-sawlani-yral merged commit 518af00 into main Apr 5, 2024
1 check passed
@ravi-sawlani-yral ravi-sawlani-yral deleted the fix/update-view-count-for-a-video branch April 5, 2024 15:41
rupansh-sekar-yral pushed a commit that referenced this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants