Skip to content
This repository has been archived by the owner on Apr 17, 2019. It is now read-only.

Change scope-name to scope.lilypond #7

Merged
merged 1 commit into from
Jan 8, 2018
Merged

Change scope-name to scope.lilypond #7

merged 1 commit into from
Jan 8, 2018

Conversation

Alhadis
Copy link
Contributor

@Alhadis Alhadis commented Dec 25, 2017

In TextMate terminology, a grammar's scopeName is equivalent to a globally-unique identifier. There's no reason this should be named anything other than source.lilypond, which falls in line with every other LilyPond grammar.

@Alhadis
Copy link
Contributor Author

Alhadis commented Jan 6, 2018

@yrammos It'd be great to get this merged and released for GitHub Linguist. Currently, my roff-language package has been forced to include two different scopeNames:to highlight regions of embedded LilyPond grammar:

  • AtLilyPond ~ Which is the scopeName used by Atom usersh who install this
  • However, there's a different LilyPond grammar with a scopeName of simply source.lilypond (as per the original TextMate package's choice of scope.. And this happens to be the package that provoides LilyPond grammar highlighting on GitHub.

I'd prefer to use only one scopeName so this error is silenced and we can help make the world a simpler place. ;)

@yrammos yrammos merged commit db55306 into yrammos:master Jan 8, 2018
@yrammos
Copy link
Owner

yrammos commented Jan 8, 2018

@Alhadis makes sense, thanks for the PR.

@Alhadis Alhadis deleted the scope-fix branch January 8, 2018 09:52
Alhadis added a commit to Alhadis/language-roff that referenced this pull request Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants