Separate adapter effects #217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # .eslintrc.js # src/types.ts
yumauri
requested changes
Aug 7, 2024
| }) as Effect<State, void, any> // as Effect<State, void, Fail<Err>> | ||
|
|
||
| const removeFx = attach({ | ||
| mapParams: () => undefined as any, |
There was a problem hiding this comment.
I'm afraid that using undefined as new storage value will break synchronization across different persisted entities... I thought about adding extra support from adapter, like, adding removeItem support for localStorage and sessionStorage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #216
Changes since @yumauri contribution to the branch:
removeEffect which is settingundefinedto storage valueclearEffect because it has to affect all storage, but current API assumes that Effects can affect only a particular entry with provided keyget->getFxset->setFxremove->removeFx