fix: Unused ticketAddressResolver #30
Closed
+17
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
el-hoshino
reviewed
Mar 12, 2024
| @@ -43,7 +43,7 @@ public struct GitFlow { | |||
|
|
|||
| } | |||
|
|
|||
| public struct Configuration { | |||
| public final class Configuration { | |||
There was a problem hiding this comment.
[ask]
struct should be good... is there any concern that needs to make it a class?
There was a problem hiding this comment.
To utilize self.ticketAddressResolver in the branchParsingMethod, it needs to be a reference type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Concerns Regarding Changes
Conversion from Struct to Class:
The PR includes a change in the type from a struct to a class. Please review and ensure that this modification aligns with the project's design principles and does not introduce unexpected behavior.
Initialization Order Change:
Additionally, there is a modification in the initialization order. It's essential to assess the impact of this change on the overall functionality of the code and confirm that it does not introduce new issues.