Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GH-229] PR 時のワークフローをステータスチェックしやすい構成に変更 #231

Merged
merged 7 commits into from
Jun 4, 2024
Merged

[GH-229] PR 時のワークフローをステータスチェックしやすい構成に変更 #231

merged 7 commits into from
Jun 4, 2024

Conversation

tatsutakein
Copy link
Member

@tatsutakein tatsutakein commented Jun 4, 2024 •
edited
Loading

TODO

  • concurrency を追加
  • pre-check のフィルター追加
  • 既存の check ステップをジョブに分解
    -> 現状は分解しないほうが速度面でメリットありそうなので実施しない
    • analyze
    • format
    • test
  • workflow_call で呼び出すように変更
  • status-check ジョブを追加

概要

PR 時のワークフローをステータスチェックしやすい構成に変更します．

レビュー観点

  • CI が通ること

レビューレベル

  • Lv1: ぱっとみて違和感がないかチェックして Approve する
  • Lv2: 仕様レベルまで理解して、仕様通りに動くかある程度検証して Approve する
  • Lv3: 実際に環境で動作確認したうえで Approve する

レビュー優先度

  • すぐに見てもらいたい ( hotfix など ) 🚀
  • 今日中に見てもらいたい 🚗
  • 今日〜明日中で見てもらいたい 🚶
  • 数日以内で見てもらいたい 🐢

画像 / 動画

Before After Design

動作確認手順

備考

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit f848f69):

https://flutter-mobile-project-template-catalog--pr231-improve-5n84aktv.web.app

(expires Tue, 11 Jun 2024 11:24:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

チェック対象ファイルの変更がなかったため、checkジョブをスキップしました

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

チェック対象ファイルの変更がなかったため、checkジョブをスキップしました

tatsutakein
tatsutakein commented Jun 4, 2024
View reviewed changes
.github/workflows/check-pr.yaml
Comment on lines +6 to +9
concurrency:
group: check-pr-${{ github.ref }}
cancel-in-progress: true

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

連続で push されたときなど，すでに実行中だった場合は以下のようにキャンセルされます．
https://github.com/yumemi-inc/flutter-mobile-project-template/actions/runs/9366181396

tatsutakein
tatsutakein commented Jun 4, 2024
View reviewed changes
.github/workflows/check-pr.yaml
@@ -25,7 +43,7 @@ jobs:

# https://github.com/peter-evans/create-or-update-comment
- name: Comment
if: ${{ steps.filter.outputs.src == 'false' }}
if: ${{ steps.filter.outputs.changes == '[]' }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dorny/paths-filter の output に changes の配列があるため，そちらを利用しています．
https://github.com/dorny/paths-filter/blob/de90cc6fb38fc0963ad72b210f1f284cd68cea36/action.yml#L48

tatsutakein
tatsutakein commented Jun 4, 2024
View reviewed changes
.github/workflows/wc-check-diff.yaml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_call なワークフローであることを示すために wc のプレフィクスをつけています．

tatsutakein
tatsutakein commented Jun 4, 2024
View reviewed changes
.github/workflows/wc-check-markdown.yaml
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflow_call なワークフローであることを示すために wc のプレフィクスをつけています．

@tatsutakein tatsutakein marked this pull request as ready for review June 4, 2024 11:32
@yumemi-team-review-requester yumemi-team-review-requester bot requested review from a team, Kotaro666-dev and mqkotoo and removed request for a team June 4, 2024 11:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2024

Ready for review 🚀

tatsutakein
tatsutakein commented Jun 4, 2024
View reviewed changes
.github/workflows/check-pr.yaml
needs: pre-check
if: ${{ needs.pre-check.outputs.markdown == 'true' }}

status-check:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

マージ後，以下のようにルール設定を変更する予定です．
https://github.com/yumemi-inc/flutter-mobile-project-template/settings/rules/258394

CleanShot 2024-06-04 at 20 35 06

@tatsutakein tatsutakein enabled auto-merge June 4, 2024 11:37
blendthink
blendthink approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@blendthink blendthink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ご対応ありがとうございます💡
LGTM です！

@tatsutakein tatsutakein merged commit f6c0582 into main Jun 4, 2024
11 checks passed
@tatsutakein tatsutakein deleted the improve/GH-229 branch June 4, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blendthink blendthink blendthink approved these changes

@Kotaro666-dev Kotaro666-dev Awaiting requested review from Kotaro666-dev Kotaro666-dev was automatically assigned from yumemi-inc/flutter_mobile_project_template

@mqkotoo mqkotoo Awaiting requested review from mqkotoo mqkotoo was automatically assigned from yumemi-inc/flutter_mobile_project_template

Assignees

@tatsutakein tatsutakein

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve]: PR 時のワークフローをステータスチェックしやすい構成に変更する
2 participants
@tatsutakein @blendthink