-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GH-189] ブランチルールのステータスチェックについてドキュメントを追加 #236
Conversation
docs/en/BRANCH.md
Outdated
# Branch | ||
|
||
Language: English | [日本語](/docs/ja/BRANCH.md) | ||
|
||
## Branch Rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ブランチ戦略の意味合いもあるのかなと思い,階層を少し変更しています
Ready for review 🚀 |
docs/en/BRANCH.md
Outdated
|
||
Language: English | [日本語](/docs/ja/BRANCH.md) | ||
|
||
## Branch Rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
英語: Branch Protection Rules
日本語: ブランチ保護ルール
とかの方がいいかなと思ったのですが、どうでしょう?
ブランチルールだとブランチの命名ルールの話にも思えるため
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ご確認ありがとうございます!
1edeb25 にて修正しました 🙆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
概要
ブランチルールのステータスチェックについてドキュメントを追加します.
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
動作確認手順
備考