ci(cli): パッケージラベルの生成ツールを追加 #250
Merged
+506
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatsutakein
changed the title
tatsutakein
force-pushed
the
improve/GH-244
branch
from
7cb19d3 to
2c7b097
Compare
|
Visit the preview URL for this PR (updated for commit a8d4737): https://flutter-mobile-project-template-catalog--pr250-improve-1618f086.web.app (expires Tue, 16 Jul 2024 05:18:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
tatsutakein
force-pushed
the
improve/GH-244
branch
from
2c7b097 to
408d5a5
Compare
tatsutakein
commented
Jun 14, 2024
There was a problem hiding this comment.
ファイルの読み込みが tool/grind.dart で固定されているようなので、他の階層には置けなそうです。
もし tools と統合するのであれば、tools 側を tool に統合することになるかなと思っています。
tatsutakein
force-pushed
the
improve/GH-244
branch
from
408d5a5 to
61db7b1
Compare
1. `dart pub global activate grinder` 2. `dart pub add grinder` 3. `dart run grinder:init`
tatsutakein
force-pushed
the
improve/GH-244
branch
from
1a34dd5 to
ad4e753
Compare
tatsutakein
commented
Jul 9, 2024
Comment on lines
+20
to
+25
| - name: Activate grinder | ||
| run: | | ||
| GRINDER_VERSION=$(cat pubspec.lock | yq ".packages.grinder.version" -r) | ||
| dart pub global activate grinder $GRINDER_VERSION | ||
| shell: bash | ||
|
|
There was a problem hiding this comment.
melos bootstrap の hook で grinder を実行するため、ここで activate しています。
tatsutakein
commented
Jul 9, 2024
| @@ -31,7 +31,7 @@ command: | |||
| test: ^1.24.0 | |||
| flutter_gen_runner: ^5.5.0+1 | |||
| hooks: | |||
| post: melos run yumemi_lints_update | |||
| post: melos run yumemi_lints_update && grind generate-package-labels && grind generate-package-labeler | |||
There was a problem hiding this comment.
実行コストはそこまでかからない認識のため hooks で実行しています。
個別での実行も可能ですが、パッケージ追加・削除時のラベル更新漏れを防ぐ意味合いです。
tatsutakein
changed the title
yumemi-team-review-requester
bot
requested review from
a team and
rizumita
and removed request for
a team
|
Ready for review 🚀 |
rizumita
approved these changes
Jul 11, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
パッケージラベルの生成ツールを追加します。
dart のコマンドラインツールとして、grinder を利用しています。
https://pub.dev/packages/grinder
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
# <!-- This is an auto-generated label -->がある状態で動作すること.github/labels.ymlは既存で同じラベル名があった場合 color などの設定が維持されること# <!-- This is an auto-generated label -->を外した状態でも動作すること動作確認手順
dart pub global activate grinderで grinder を実行できるようにした後、以下のいずれかのコマンドを実行します。melos bsgrind generate-package-labelsとgrind generate-package-labelerが実行されますgrind generate-package-labels.github/labels.ymlのパッケージ部分が生成されますgrind generate-package-labeler.github/labeler.ymlのパッケージ部分が生成されます備考