ci: 初期に自動的に登録される Issue を整理 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 6434396): https://flutter-mobile-project-template-catalog--pr285-improve-xqj6wa90.web.app (expires Mon, 29 Jul 2024 04:40:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9ea56735a63d07a7cfe62eb204b0528284c37c23 |
tatsutakein
force-pushed
the
improve/GH-274
branch
from
02ad782 to
9b758d1
Compare
tatsutakein
force-pushed
the
improve/GH-274
branch
from
9b758d1 to
4ca2460
Compare
tatsutakein
commented
Jul 22, 2024
Comment on lines
+4
to
+8
| inputs: | ||
| language: | ||
| description: "The language of the issue to create. ja / en are supported, and ja is set by default." | ||
| default: "ja" | ||
|
|
There was a problem hiding this comment.
今回は対応しませんが、今後英語での Issue 作成にも対応しやすいよう言語の指定を受け付けるようにしています。
tatsutakein
commented
Jul 22, 2024
| # https://github.com/marketplace/actions/create-issue-from-file | ||
| - uses: peter-evans/create-issue-from-file@24452a72d85239eacf1468b0f1982a9f3fec4c94 # v5.0.0 | ||
| with: | ||
| title: "[初期セットアップ（任意）] スプラッシュ画面の設定" |
There was a problem hiding this comment.
スプラッシュは任意で良いかなと思って (任意) をつけていますが、必須にしたほうがよさそうであれば変更します。
tatsutakein
commented
Jul 22, 2024
Comment on lines
+9
to
+20
| condition: | ||
| runs-on: ubuntu-22.04 | ||
| outputs: | ||
| execute: ${{ steps.condition.outputs.execute }} | ||
| steps: | ||
| - id: condition | ||
| run: | | ||
| if [[ "${{ github.event.repository.name }}" != "flutter-mobile-project-template" ]]; then | ||
| echo "execute=true" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "execute=false" >> "$GITHUB_OUTPUT" | ||
| fi |
There was a problem hiding this comment.
job が分かれていた方が視覚化できて良さそうだったので分けてみました。
tatsutakein
commented
Jul 22, 2024
| permissions: | ||
| contents: write |
There was a problem hiding this comment.
job を分割したことで、その job で必要な権限が明確になります 🙆
yumemi-team-review-requester
bot
requested review from
a team,
Aosanori and
mqkotoo
and removed request for
a team
|
Ready for review 🚀 |
blendthink
approved these changes
Jul 23, 2024
| @@ -1,20 +1,31 @@ | |||
| name: Template Cleanup | |||
| name: Initialization | |||
There was a problem hiding this comment.
Cleanup というより Initialization のほうが適していそうですね！
修正ありがとうございます！
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
初期に自動的に登録される Issue を整理します。
レビュー観点
レビューレベル
レビュー優先度
画像 / 動画
確認したこと
Use this templateを実施可能であることUse this templateでリポジトリ作成後に action が動作し Issue が作成されること動作確認手順
備考